GH-38738: [C++] Check variadic buffer counts in bounds #38740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
awaiting committer review
|
Should the fuzzer testcases be added to testing/data/arrow-ipc-stream/ ? |
pitrou
reviewed
Nov 23, 2023
pitrou
approved these changes
Nov 23, 2023
Yes, they should |
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
|
fuzz regression file added in apache/arrow-testing#98 |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 84c15da. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…38740) ### Rationale for this change Invalid variadic buffer counts can cause allocating storage for variadic buffers to fail. ### What changes are included in this PR? Check variadic buffer counts are valid before they are used as an allocator argument. ### Are these changes tested? They pass with the fuzzer testcase. ### Are there any user-facing changes? No * Closes: apache#38738 Lead-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Co-authored-by: Antoine Pitrou <pitrou@free.fr> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Invalid variadic buffer counts can cause allocating storage for variadic buffers to fail.
What changes are included in this PR?
Check variadic buffer counts are valid before they are used as an allocator argument.
Are these changes tested?
They pass with the fuzzer testcase.
Are there any user-facing changes?
No